kosslan/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

service/tray: delete image pixmaps created with new[] using delete[]

Browse source
This commit is contained in:
outfoxxed 2024-09-15 13:50:00 -07:00
parent 01f2be057e
commit bdc9fe958b
Signed by: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/services/status_notifier/dbus_item_types.cpp
View file

@ -14,7 +14,7 @@ QImage DBusSniIconPixmap::createImage() const {
// fix byte order if on a little endian machine // fix byte order if on a little endian machine
if (QSysInfo::ByteOrder == QSysInfo::LittleEndian) { if (QSysInfo::ByteOrder == QSysInfo::LittleEndian) {
auto* newbuf = new quint32[this->data.size()]; auto* newbuf = new quint32[this->data.size()];
const auto* oldbuf = reinterpret_cast<const quint32*>(this->data.data()); // NOLINT const auto* oldbuf = reinterpret_cast<const quint32*>(this->data.constData()); // NOLINT
for (uint i = 0; i < this->data.size() / sizeof(quint32); ++i) { for (uint i = 0; i < this->data.size() / sizeof(quint32); ++i) {
newbuf[i] = qFromBigEndian(oldbuf[i]); // NOLINT newbuf[i] = qFromBigEndian(oldbuf[i]); // NOLINT
@ -25,12 +25,12 @@ QImage DBusSniIconPixmap::createImage() const {
this->width, this->width,
this->height, this->height,
QImage::Format_ARGB32, QImage::Format_ARGB32,
[](void* ptr) { delete reinterpret_cast<quint32*>(ptr); }, // NOLINT [](void* ptr) { delete[] reinterpret_cast<quint32*>(ptr); }, // NOLINT
newbuf newbuf
); );
} else { } else {
return QImage( return QImage(
reinterpret_cast<const uchar*>(this->data.data()), // NOLINT reinterpret_cast<const uchar*>(this->data.constData()), // NOLINT
this->width, this->width,
this->height, this->height,
QImage::Format_ARGB32 QImage::Format_ARGB32