From bdc9fe958bc261dd887b4de2466732e63c96ed21 Mon Sep 17 00:00:00 2001 From: outfoxxed Date: Sun, 15 Sep 2024 13:50:00 -0700 Subject: [PATCH] service/tray: delete image pixmaps created with new[] using delete[] --- src/services/status_notifier/dbus_item_types.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/status_notifier/dbus_item_types.cpp b/src/services/status_notifier/dbus_item_types.cpp index 567f4644..afb623ef 100644 --- a/src/services/status_notifier/dbus_item_types.cpp +++ b/src/services/status_notifier/dbus_item_types.cpp @@ -14,7 +14,7 @@ QImage DBusSniIconPixmap::createImage() const { // fix byte order if on a little endian machine if (QSysInfo::ByteOrder == QSysInfo::LittleEndian) { auto* newbuf = new quint32[this->data.size()]; - const auto* oldbuf = reinterpret_cast(this->data.data()); // NOLINT + const auto* oldbuf = reinterpret_cast(this->data.constData()); // NOLINT for (uint i = 0; i < this->data.size() / sizeof(quint32); ++i) { newbuf[i] = qFromBigEndian(oldbuf[i]); // NOLINT @@ -25,12 +25,12 @@ QImage DBusSniIconPixmap::createImage() const { this->width, this->height, QImage::Format_ARGB32, - [](void* ptr) { delete reinterpret_cast(ptr); }, // NOLINT + [](void* ptr) { delete[] reinterpret_cast(ptr); }, // NOLINT newbuf ); } else { return QImage( - reinterpret_cast(this->data.data()), // NOLINT + reinterpret_cast(this->data.constData()), // NOLINT this->width, this->height, QImage::Format_ARGB32