kosslan/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

service/mpris!: convert trackArtists from list<string> to string

Browse source 
Most people treat it as a string already, which breaks in Qt 6.8,
and I have not seen a meaningful multi-artist response.
This commit is contained in:
outfoxxed 2024-11-19 18:28:19 -08:00
parent dbaaf55eb6
commit 8450543e09
Signed by: outfoxxed
GPG key ID: 4C88A185FB89301E
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/services/mpris/player.cpp
View file

@ -301,7 +301,7 @@ void MprisPlayer::onMetadataChanged() {
auto trackTitleChanged = this->setTrackTitle(trackTitle.isNull() ? "Unknown Track" : trackTitle);
auto trackArtists = this->pMetadata.get().value("xesam:artist").value<QVector<QString>>();
auto trackArtistsChanged = this->setTrackArtists(trackArtists);
auto trackArtistsChanged = this->setTrackArtists(trackArtists.join(", "));
auto trackAlbum = this->pMetadata.get().value("xesam:album").toString();
auto trackAlbumChanged = this->setTrackAlbum(trackAlbum.isNull() ? "Unknown Album" : trackAlbum);

4
src/services/mpris/player.hpp
View file

@ -141,7 +141,7 @@ class MprisPlayer: public QObject {
/// The current track's album artist, or "Unknown Artist" if none was provided.
Q_PROPERTY(QString trackAlbumArtist READ trackAlbumArtist NOTIFY trackAlbumArtistChanged);
/// The current track's artists, or an empty list if none were provided.
Q_PROPERTY(QVector<QString> trackArtists READ trackArtists NOTIFY trackArtistsChanged);
Q_PROPERTY(QString trackArtists READ trackArtists NOTIFY trackArtistsChanged);
/// The current track's art url, or `""` if none was provided.
Q_PROPERTY(QString trackArtUrl READ trackArtUrl NOTIFY trackArtUrlChanged);
/// The playback state of the media player.
@ -373,7 +373,7 @@ private:
QString mTrackId;
QString mTrackUrl;
QString mTrackTitle;
QVector<QString> mTrackArtists;
QString mTrackArtists;
QString mTrackAlbum;
QString mTrackAlbumArtist;
QString mTrackArtUrl;