From 8450543e09125fa4a5797bc03146da29e004692e Mon Sep 17 00:00:00 2001 From: outfoxxed Date: Tue, 19 Nov 2024 18:28:19 -0800 Subject: [PATCH] service/mpris!: convert trackArtists from list to string Most people treat it as a string already, which breaks in Qt 6.8, and I have not seen a meaningful multi-artist response. --- src/services/mpris/player.cpp | 2 +- src/services/mpris/player.hpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/mpris/player.cpp b/src/services/mpris/player.cpp index b2d4af60..8629d592 100644 --- a/src/services/mpris/player.cpp +++ b/src/services/mpris/player.cpp @@ -301,7 +301,7 @@ void MprisPlayer::onMetadataChanged() { auto trackTitleChanged = this->setTrackTitle(trackTitle.isNull() ? "Unknown Track" : trackTitle); auto trackArtists = this->pMetadata.get().value("xesam:artist").value>(); - auto trackArtistsChanged = this->setTrackArtists(trackArtists); + auto trackArtistsChanged = this->setTrackArtists(trackArtists.join(", ")); auto trackAlbum = this->pMetadata.get().value("xesam:album").toString(); auto trackAlbumChanged = this->setTrackAlbum(trackAlbum.isNull() ? "Unknown Album" : trackAlbum); diff --git a/src/services/mpris/player.hpp b/src/services/mpris/player.hpp index 47ea7922..9e633555 100644 --- a/src/services/mpris/player.hpp +++ b/src/services/mpris/player.hpp @@ -141,7 +141,7 @@ class MprisPlayer: public QObject { /// The current track's album artist, or "Unknown Artist" if none was provided. Q_PROPERTY(QString trackAlbumArtist READ trackAlbumArtist NOTIFY trackAlbumArtistChanged); /// The current track's artists, or an empty list if none were provided. - Q_PROPERTY(QVector trackArtists READ trackArtists NOTIFY trackArtistsChanged); + Q_PROPERTY(QString trackArtists READ trackArtists NOTIFY trackArtistsChanged); /// The current track's art url, or `""` if none was provided. Q_PROPERTY(QString trackArtUrl READ trackArtUrl NOTIFY trackArtUrlChanged); /// The playback state of the media player. @@ -373,7 +373,7 @@ private: QString mTrackId; QString mTrackUrl; QString mTrackTitle; - QVector mTrackArtists; + QString mTrackArtists; QString mTrackAlbum; QString mTrackAlbumArtist; QString mTrackArtUrl;