quickshell/quickshell
1
1
Fork 2
Code Issues Wiki Activity

service/tray: silence compliance warnings

Browse source 
Almost every tray item is missing properties and these
messages pollute the log, masking more useful warnings.
This commit is contained in:
outfoxxed 2025-05-16 00:11:09 -07:00
parent eb391e35fe
commit 823456b58e
Signed by: outfoxxed
GPG key ID: 4C88A185FB89301E
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/services/status_notifier/item.cpp
View file

@ -65,19 +65,19 @@ StatusNotifierItem::StatusNotifierItem(const QString& address, QObject* parent)
QObject::connect(this->item, &DBusStatusNotifierItem::NewIcon, this, [this]() {
this->pIconName.requestUpdate();
this->pIconPixmaps.requestUpdate();
this->pIconThemePath.requestUpdate();
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
});
QObject::connect(this->item, &DBusStatusNotifierItem::NewOverlayIcon, this, [this]() {
this->pOverlayIconName.requestUpdate();
this->pOverlayIconPixmaps.requestUpdate();
this->pIconThemePath.requestUpdate();
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
});
QObject::connect(this->item, &DBusStatusNotifierItem::NewAttentionIcon, this, [this]() {
this->pAttentionIconName.requestUpdate();
this->pAttentionIconPixmaps.requestUpdate();
this->pIconThemePath.requestUpdate();
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
});
QObject::connect(this->item, &DBusStatusNotifierItem::NewToolTip, this, [this]() {

14
src/services/status_notifier/item.hpp
View file

@ -213,18 +213,18 @@ private:
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pId, bId, properties, "Id");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pTitle, bTitle, properties, "Title");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pStatus, bStatus, properties, "Status");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pCategory, bCategory, properties, "Category");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pCategory, bCategory, properties, "Category", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconThemePath, bIconThemePath, properties, "IconThemePath", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconName, bIconName, properties, "IconName", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconPixmaps, bIconPixmaps, properties, "IconPixmap", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconName, bOverlayIconName, properties, "OverlayIconName");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconPixmaps, bOverlayIconPixmaps, properties, "OverlayIconPixmap");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconName, bAttentionIconName, properties, "AttentionIconName");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconPixmaps, bAttentionIconPixmaps, properties, "AttentionIconPixmap");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconName, bOverlayIconName, properties, "OverlayIconName", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconPixmaps, bOverlayIconPixmaps, properties, "OverlayIconPixmap", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconName, bAttentionIconName, properties, "AttentionIconName", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconPixmaps, bAttentionIconPixmaps, properties, "AttentionIconPixmap", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionMovieName, bAttentionMovieName, properties, "AttentionMovieName", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pTooltip, bTooltip, properties, "ToolTip");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIsMenu, bIsMenu, properties, "ItemIsMenu");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pMenuPath, bMenuPath, properties, "Menu");
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIsMenu, bIsMenu, properties, "ItemIsMenu", false);
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pMenuPath, bMenuPath, properties, "Menu", false);
// clang-format on
};