poz/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

services/pipewire: destroy bound audio object when node is destroyed

Browse source 
Fixes a leak and prevents a UAF via device volume signals
derefing the freed node.

Fixes #91
This commit is contained in:
outfoxxed 2025-07-04 20:29:50 -07:00
parent 7eff415b25
commit 87d99b866f
Signed by untrusted user: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/services/pipewire/node.cpp
View file

@ -252,7 +252,7 @@ void PwNode::onParam(
} }
} }
PwNodeBoundAudio::PwNodeBoundAudio(PwNode* node): node(node) { PwNodeBoundAudio::PwNodeBoundAudio(PwNode* node): QObject(node), node(node) {
if (node->device) { if (node->device) {
QObject::connect(node->device, &PwDevice::deviceReady, this, &PwNodeBoundAudio::onDeviceReady); QObject::connect(node->device, &PwDevice::deviceReady, this, &PwNodeBoundAudio::onDeviceReady);