poz/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

core/log: stop trying to store detailed logs after write fail

Browse source 
Not stopping will cause the logger's write buffer to fill until OOM if
writing fails.
This commit is contained in:
outfoxxed 2025-07-19 03:41:24 -07:00
parent 63a6d27213
commit 759bd721df
Signed by untrusted user: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/core/logging.cpp
View file

@ -457,10 +457,14 @@ void ThreadLogging::onMessage(const LogMessage& msg, bool showInSparse) {
this->fileStream << Qt::endl; this->fileStream << Qt::endl;
} }
if (this->detailedWriter.write(msg)) { if (!this->detailedWriter.write(msg) || (this->detailedFile && !this->detailedFile->flush())) {
this->detailedFile->flush(); if (this->detailedFile) {
} else if (this->detailedFile != nullptr) { qCCritical(logLogging) << "Detailed logger failed to write. Ending detailed logs.";
qCCritical(logLogging) << "Detailed logger failed to write. Ending detailed logs."; }
this->detailedWriter.setDevice(nullptr);
this->detailedFile->close();
this->detailedFile = nullptr;
} }
} }