poz/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

core/reloader: delay post-reload reload hooks

Browse source 
Ensures onReload runs after Component.onCompleted.
This commit is contained in:
outfoxxed 2024-08-18 19:54:36 -07:00
parent 5a038f085d
commit 5040f3796c
Signed by untrusted user: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/core/reload.cpp
View file

@ -3,6 +3,7 @@
#include <qcontainerfwd.h> #include <qcontainerfwd.h>
#include <qobject.h> #include <qobject.h>
#include <qqmllist.h> #include <qqmllist.h>
#include <qtimer.h>
#include "generation.hpp" #include "generation.hpp"
@ -12,8 +13,10 @@ void Reloadable::componentComplete() {
if (this->engineGeneration != nullptr) { if (this->engineGeneration != nullptr) {
// When called this way there is no chance a reload will have old data, // When called this way there is no chance a reload will have old data,
// but this will at least help prevent weird behaviors due to never getting a reload. // but this will at least help prevent weird behaviors due to never getting a reload.
if (this->engineGeneration->reloadComplete) this->reload(); if (this->engineGeneration->reloadComplete) {
else { // Delayed due to Component.onCompleted running after QQmlParserStatus::componentComplete.
QTimer::singleShot(0, this, &Reloadable::onReloadFinished);
} else {
QObject::connect( QObject::connect(
this->engineGeneration, this->engineGeneration,
&EngineGeneration::reloadFinished, &EngineGeneration::reloadFinished,