From 4dad44757085a42423f758bf0177cebcd07b4a4a Mon Sep 17 00:00:00 2001 From: outfoxxed Date: Thu, 24 Jul 2025 16:44:10 -0700 Subject: [PATCH] docs: remove }; in headers + typo fixes }; breaks the docgen regex --- src/core/desktopentry.hpp | 2 +- src/core/model.hpp | 2 +- src/core/qsmenu.hpp | 4 +- src/core/reload.hpp | 2 +- src/dbus/properties.hpp | 6 +- src/io/datastream.hpp | 4 +- src/io/ipchandler.hpp | 2 +- src/services/mpris/player.hpp | 62 ++++++++++----------- src/services/mpris/watcher.hpp | 2 +- src/services/notifications/notification.hpp | 28 +++++----- src/services/pipewire/registry.hpp | 4 +- src/services/upower/core.hpp | 2 +- src/services/upower/device.hpp | 34 +++++------ src/widgets/wrapper.hpp | 4 +- 14 files changed, 79 insertions(+), 79 deletions(-) diff --git a/src/core/desktopentry.hpp b/src/core/desktopentry.hpp index 34137728..827a6187 100644 --- a/src/core/desktopentry.hpp +++ b/src/core/desktopentry.hpp @@ -195,7 +195,7 @@ public: /// While this function requires an exact match, @@heuristicLookup() will correctly /// find an entry more often and is generally more useful. Q_INVOKABLE [[nodiscard]] static DesktopEntry* byId(const QString& id); - /// Look up a desktop entry by name using heuristics. Unline @@byId(), + /// Look up a desktop entry by name using heuristics. Unlike @@byId(), /// if no exact matches are found this function will try to guess - potentially incorrectly. /// May return null. Q_INVOKABLE [[nodiscard]] static DesktopEntry* heuristicLookup(const QString& name); diff --git a/src/core/model.hpp b/src/core/model.hpp index 6346c96b..3c5822a4 100644 --- a/src/core/model.hpp +++ b/src/core/model.hpp @@ -53,7 +53,7 @@ public: [[nodiscard]] QVariant data(const QModelIndex& index, qint32 role) const override; [[nodiscard]] QHash roleNames() const override; - [[nodiscard]] QList values() const { return this->valuesList; }; + [[nodiscard]] QList values() const { return this->valuesList; } void removeAt(qsizetype index); Q_INVOKABLE qsizetype indexOf(QObject* object); diff --git a/src/core/qsmenu.hpp b/src/core/qsmenu.hpp index 6684c686..90df8b9a 100644 --- a/src/core/qsmenu.hpp +++ b/src/core/qsmenu.hpp @@ -46,8 +46,8 @@ class QsMenuHandle: public QObject { public: explicit QsMenuHandle(QObject* parent): QObject(parent) {} - virtual void refHandle() {}; - virtual void unrefHandle() {}; + virtual void refHandle() {} + virtual void unrefHandle() {} [[nodiscard]] virtual QsMenuEntry* menu() = 0; diff --git a/src/core/reload.hpp b/src/core/reload.hpp index 1117eb81..0ed34eea 100644 --- a/src/core/reload.hpp +++ b/src/core/reload.hpp @@ -57,7 +57,7 @@ public: void reload(QObject* oldInstance = nullptr); - void classBegin() override {}; + void classBegin() override {} void componentComplete() override; // Reload objects in the parent->child graph recursively. diff --git a/src/dbus/properties.hpp b/src/dbus/properties.hpp index a5fce98c..f6a63300 100644 --- a/src/dbus/properties.hpp +++ b/src/dbus/properties.hpp @@ -168,9 +168,9 @@ class DBusBindableProperty: public DBusPropertyCore { public: explicit DBusBindableProperty() { this->group()->attachProperty(this); } - [[nodiscard]] QString name() const override { return Name; }; - [[nodiscard]] QStringView nameRef() const override { return Name; }; - [[nodiscard]] bool isRequired() const override { return required; }; + [[nodiscard]] QString name() const override { return Name; } + [[nodiscard]] QStringView nameRef() const override { return Name; } + [[nodiscard]] bool isRequired() const override { return required; } [[nodiscard]] QString valueString() override { QString str; diff --git a/src/io/datastream.hpp b/src/io/datastream.hpp index d83e571e..b91ec044 100644 --- a/src/io/datastream.hpp +++ b/src/io/datastream.hpp @@ -55,7 +55,7 @@ public: // the buffer will be sent in both slots if there is data remaining from a previous parser virtual void parseBytes(QByteArray& incoming, QByteArray& buffer) = 0; - virtual void streamEnded(QByteArray& /*buffer*/) {}; + virtual void streamEnded(QByteArray& /*buffer*/) {} signals: /// Emitted when data is read from the stream. @@ -63,7 +63,7 @@ signals: }; ///! DataStreamParser for delimited data streams. -/// DataStreamParser for delimited data streams. @@read() is emitted once per delimited chunk of the stream. +/// DataStreamParser for delimited data streams. @@DataStreamParser.read(s) is emitted once per delimited chunk of the stream. class SplitParser: public DataStreamParser { Q_OBJECT; /// The delimiter for parsed data. May be multiple characters. Defaults to `\n`. diff --git a/src/io/ipchandler.hpp b/src/io/ipchandler.hpp index 1da3e712..4c5d9bc1 100644 --- a/src/io/ipchandler.hpp +++ b/src/io/ipchandler.hpp @@ -164,7 +164,7 @@ class IpcHandler: public PostReloadHook { QML_ELEMENT; public: - explicit IpcHandler(QObject* parent = nullptr): PostReloadHook(parent) {}; + explicit IpcHandler(QObject* parent = nullptr): PostReloadHook(parent) {} ~IpcHandler() override; Q_DISABLE_COPY_MOVE(IpcHandler); diff --git a/src/services/mpris/player.hpp b/src/services/mpris/player.hpp index 93837c6d..423453d3 100644 --- a/src/services/mpris/player.hpp +++ b/src/services/mpris/player.hpp @@ -274,23 +274,23 @@ public: [[nodiscard]] bool isValid() const; [[nodiscard]] QString address() const; - [[nodiscard]] QBindable bindableCanControl() const { return &this->bCanControl; }; - [[nodiscard]] QBindable bindableCanSeek() const { return &this->bCanSeek; }; - [[nodiscard]] QBindable bindableCanGoNext() const { return &this->bCanGoNext; }; - [[nodiscard]] QBindable bindableCanGoPrevious() const { return &this->bCanGoPrevious; }; - [[nodiscard]] QBindable bindableCanPlay() const { return &this->bCanPlay; }; - [[nodiscard]] QBindable bindableCanPause() const { return &this->bCanPause; }; + [[nodiscard]] QBindable bindableCanControl() const { return &this->bCanControl; } + [[nodiscard]] QBindable bindableCanSeek() const { return &this->bCanSeek; } + [[nodiscard]] QBindable bindableCanGoNext() const { return &this->bCanGoNext; } + [[nodiscard]] QBindable bindableCanGoPrevious() const { return &this->bCanGoPrevious; } + [[nodiscard]] QBindable bindableCanPlay() const { return &this->bCanPlay; } + [[nodiscard]] QBindable bindableCanPause() const { return &this->bCanPause; } [[nodiscard]] QBindable bindableCanTogglePlaying() const { return &this->bCanTogglePlaying; - }; - [[nodiscard]] QBindable bindableCanQuit() const { return &this->bCanQuit; }; - [[nodiscard]] QBindable bindableCanRaise() const { return &this->bCanRaise; }; + } + [[nodiscard]] QBindable bindableCanQuit() const { return &this->bCanQuit; } + [[nodiscard]] QBindable bindableCanRaise() const { return &this->bCanRaise; } [[nodiscard]] QBindable bindableCanSetFullscreen() const { return &this->bCanSetFullscreen; - }; + } - [[nodiscard]] QBindable bindableIdentity() const { return &this->bIdentity; }; - [[nodiscard]] QBindable bindableDesktopEntry() const { return &this->bDesktopEntry; }; + [[nodiscard]] QBindable bindableIdentity() const { return &this->bIdentity; } + [[nodiscard]] QBindable bindableDesktopEntry() const { return &this->bDesktopEntry; } [[nodiscard]] qlonglong positionMs() const; [[nodiscard]] qreal position() const; @@ -300,49 +300,49 @@ public: [[nodiscard]] qreal length() const; [[nodiscard]] QBindable bindableLengthSupported() const { return &this->bLengthSupported; } - [[nodiscard]] qreal volume() const { return this->bVolume; }; + [[nodiscard]] qreal volume() const { return this->bVolume; } [[nodiscard]] bool volumeSupported() const; void setVolume(qreal volume); - [[nodiscard]] QBindable bindableUniqueId() const { return &this->bUniqueId; }; - [[nodiscard]] QBindable bindableMetadata() const { return &this->bMetadata; }; - [[nodiscard]] QBindable bindableTrackTitle() const { return &this->bTrackTitle; }; - [[nodiscard]] QBindable bindableTrackAlbum() const { return &this->bTrackAlbum; }; + [[nodiscard]] QBindable bindableUniqueId() const { return &this->bUniqueId; } + [[nodiscard]] QBindable bindableMetadata() const { return &this->bMetadata; } + [[nodiscard]] QBindable bindableTrackTitle() const { return &this->bTrackTitle; } + [[nodiscard]] QBindable bindableTrackAlbum() const { return &this->bTrackAlbum; } [[nodiscard]] QBindable bindableTrackAlbumArtist() const { return &this->bTrackAlbumArtist; - }; - [[nodiscard]] QBindable bindableTrackArtist() const { return &this->bTrackArtist; }; - [[nodiscard]] QBindable bindableTrackArtUrl() const { return &this->bTrackArtUrl; }; + } + [[nodiscard]] QBindable bindableTrackArtist() const { return &this->bTrackArtist; } + [[nodiscard]] QBindable bindableTrackArtUrl() const { return &this->bTrackArtUrl; } - [[nodiscard]] MprisPlaybackState::Enum playbackState() const { return this->bPlaybackState; }; + [[nodiscard]] MprisPlaybackState::Enum playbackState() const { return this->bPlaybackState; } void setPlaybackState(MprisPlaybackState::Enum playbackState); - [[nodiscard]] bool isPlaying() const { return this->bIsPlaying; }; + [[nodiscard]] bool isPlaying() const { return this->bIsPlaying; } void setPlaying(bool playing); - [[nodiscard]] MprisLoopState::Enum loopState() const { return this->bLoopState; }; + [[nodiscard]] MprisLoopState::Enum loopState() const { return this->bLoopState; } [[nodiscard]] bool loopSupported() const; void setLoopState(MprisLoopState::Enum loopState); - [[nodiscard]] qreal rate() const { return this->bRate; }; - [[nodiscard]] QBindable bindableMinRate() const { return &this->bRate; }; - [[nodiscard]] QBindable bindableMaxRate() const { return &this->bRate; }; + [[nodiscard]] qreal rate() const { return this->bRate; } + [[nodiscard]] QBindable bindableMinRate() const { return &this->bRate; } + [[nodiscard]] QBindable bindableMaxRate() const { return &this->bRate; } void setRate(qreal rate); - [[nodiscard]] bool shuffle() const { return this->bShuffle; }; + [[nodiscard]] bool shuffle() const { return this->bShuffle; } [[nodiscard]] bool shuffleSupported() const; void setShuffle(bool shuffle); - [[nodiscard]] bool fullscreen() const { return this->bFullscreen; }; + [[nodiscard]] bool fullscreen() const { return this->bFullscreen; } void setFullscreen(bool fullscreen); [[nodiscard]] QBindable> bindableSupportedUriSchemes() const { return &this->bSupportedUriSchemes; - }; + } [[nodiscard]] QBindable> bindableSupportedMimeTypes() const { return &this->bSupportedMimeTypes; - }; + } signals: /// The track has changed. @@ -414,7 +414,7 @@ private: void onPlaybackStatusUpdated(); // call instead of setting bpPosition void setPosition(qlonglong position); - void requestPositionUpdate() { this->pPosition.requestUpdate(); }; + void requestPositionUpdate() { this->pPosition.requestUpdate(); } // clang-format off Q_OBJECT_BINDABLE_PROPERTY(MprisPlayer, QString, bIdentity, &MprisPlayer::identityChanged); diff --git a/src/services/mpris/watcher.hpp b/src/services/mpris/watcher.hpp index bd922cd3..cbe96690 100644 --- a/src/services/mpris/watcher.hpp +++ b/src/services/mpris/watcher.hpp @@ -51,7 +51,7 @@ class MprisQml: public QObject { Q_PROPERTY(UntypedObjectModel* players READ players CONSTANT); public: - explicit MprisQml(QObject* parent = nullptr): QObject(parent) {}; + explicit MprisQml(QObject* parent = nullptr): QObject(parent) {} [[nodiscard]] ObjectModel* players(); }; diff --git a/src/services/notifications/notification.hpp b/src/services/notifications/notification.hpp index fc3f30be..7f5246c1 100644 --- a/src/services/notifications/notification.hpp +++ b/src/services/notifications/notification.hpp @@ -154,29 +154,29 @@ public: [[nodiscard]] bool isLastGeneration() const; void setLastGeneration(); - [[nodiscard]] QBindable bindableExpireTimeout() const { return &this->bExpireTimeout; }; - [[nodiscard]] QBindable bindableAppName() const { return &this->bAppName; }; - [[nodiscard]] QBindable bindableAppIcon() const { return &this->bAppIcon; }; - [[nodiscard]] QBindable bindableSummary() const { return &this->bSummary; }; - [[nodiscard]] QBindable bindableBody() const { return &this->bBody; }; + [[nodiscard]] QBindable bindableExpireTimeout() const { return &this->bExpireTimeout; } + [[nodiscard]] QBindable bindableAppName() const { return &this->bAppName; } + [[nodiscard]] QBindable bindableAppIcon() const { return &this->bAppIcon; } + [[nodiscard]] QBindable bindableSummary() const { return &this->bSummary; } + [[nodiscard]] QBindable bindableBody() const { return &this->bBody; } [[nodiscard]] QBindable bindableUrgency() const { return &this->bUrgency; - }; + } [[nodiscard]] QList actions() const; - [[nodiscard]] QBindable bindableHasActionIcons() const { return &this->bHasActionIcons; }; - [[nodiscard]] QBindable bindableResident() const { return &this->bResident; }; - [[nodiscard]] QBindable bindableTransient() const { return &this->bTransient; }; - [[nodiscard]] QBindable bindableDesktopEntry() const { return &this->bDesktopEntry; }; - [[nodiscard]] QBindable bindableImage() const { return &this->bImage; }; - [[nodiscard]] QBindable bindableHasInlineReply() const { return &this->bHasInlineReply; }; + [[nodiscard]] QBindable bindableHasActionIcons() const { return &this->bHasActionIcons; } + [[nodiscard]] QBindable bindableResident() const { return &this->bResident; } + [[nodiscard]] QBindable bindableTransient() const { return &this->bTransient; } + [[nodiscard]] QBindable bindableDesktopEntry() const { return &this->bDesktopEntry; } + [[nodiscard]] QBindable bindableImage() const { return &this->bImage; } + [[nodiscard]] QBindable bindableHasInlineReply() const { return &this->bHasInlineReply; } [[nodiscard]] QBindable bindableInlineReplyPlaceholder() const { return &this->bInlineReplyPlaceholder; - }; + } - [[nodiscard]] QBindable bindableHints() const { return &this->bHints; }; + [[nodiscard]] QBindable bindableHints() const { return &this->bHints; } [[nodiscard]] NotificationCloseReason::Enum closeReason() const; void setTracked(bool tracked); diff --git a/src/services/pipewire/registry.hpp b/src/services/pipewire/registry.hpp index 14ea4055..8473f041 100644 --- a/src/services/pipewire/registry.hpp +++ b/src/services/pipewire/registry.hpp @@ -55,8 +55,8 @@ protected: void registryBind(const char* interface, quint32 version); virtual void bind(); void unbind(); - virtual void bindHooks() {}; - virtual void unbindHooks() {}; + virtual void bindHooks() {} + virtual void unbindHooks() {} quint32 refcount = 0; pw_proxy* object = nullptr; diff --git a/src/services/upower/core.hpp b/src/services/upower/core.hpp index e2ed4f7b..62fca1d9 100644 --- a/src/services/upower/core.hpp +++ b/src/services/upower/core.hpp @@ -22,7 +22,7 @@ class UPower: public QObject { public: [[nodiscard]] UPowerDevice* displayDevice(); [[nodiscard]] ObjectModel* devices(); - [[nodiscard]] QBindable bindableOnBattery() const { return &this->bOnBattery; }; + [[nodiscard]] QBindable bindableOnBattery() const { return &this->bOnBattery; } static UPower* instance(); diff --git a/src/services/upower/device.hpp b/src/services/upower/device.hpp index b2b5f021..a4fbe836 100644 --- a/src/services/upower/device.hpp +++ b/src/services/upower/device.hpp @@ -173,25 +173,25 @@ public: [[nodiscard]] QString address() const; [[nodiscard]] QString path() const; - [[nodiscard]] QBindable bindableType() const { return &this->bType; }; - [[nodiscard]] QBindable bindablePowerSupply() const { return &this->bPowerSupply; }; - [[nodiscard]] QBindable bindableEnergy() const { return &this->bEnergy; }; - [[nodiscard]] QBindable bindableEnergyCapacity() const { return &this->bEnergyCapacity; }; - [[nodiscard]] QBindable bindableChangeRate() const { return &this->bChangeRate; }; - [[nodiscard]] QBindable bindableTimeToEmpty() const { return &this->bTimeToEmpty; }; - [[nodiscard]] QBindable bindableTimeToFull() const { return &this->bTimeToFull; }; - [[nodiscard]] QBindable bindablePercentage() const { return &this->bPercentage; }; - [[nodiscard]] QBindable bindableIsPresent() const { return &this->bIsPresent; }; - [[nodiscard]] QBindable bindableState() const { return &this->bState; }; + [[nodiscard]] QBindable bindableType() const { return &this->bType; } + [[nodiscard]] QBindable bindablePowerSupply() const { return &this->bPowerSupply; } + [[nodiscard]] QBindable bindableEnergy() const { return &this->bEnergy; } + [[nodiscard]] QBindable bindableEnergyCapacity() const { return &this->bEnergyCapacity; } + [[nodiscard]] QBindable bindableChangeRate() const { return &this->bChangeRate; } + [[nodiscard]] QBindable bindableTimeToEmpty() const { return &this->bTimeToEmpty; } + [[nodiscard]] QBindable bindableTimeToFull() const { return &this->bTimeToFull; } + [[nodiscard]] QBindable bindablePercentage() const { return &this->bPercentage; } + [[nodiscard]] QBindable bindableIsPresent() const { return &this->bIsPresent; } + [[nodiscard]] QBindable bindableState() const { return &this->bState; } [[nodiscard]] QBindable bindableHealthPercentage() const { return &this->bHealthPercentage; - }; - [[nodiscard]] QBindable bindableHealthSupported() const { return &this->bHealthSupported; }; - [[nodiscard]] QBindable bindableIconName() const { return &this->bIconName; }; - [[nodiscard]] QBindable bindableIsLaptopBattery() const { return &this->bIsLaptopBattery; }; - [[nodiscard]] QBindable bindableNativePath() const { return &this->bNativePath; }; - [[nodiscard]] QBindable bindableModel() const { return &this->bModel; }; - [[nodiscard]] QBindable bindableReady() const { return &this->bReady; }; + } + [[nodiscard]] QBindable bindableHealthSupported() const { return &this->bHealthSupported; } + [[nodiscard]] QBindable bindableIconName() const { return &this->bIconName; } + [[nodiscard]] QBindable bindableIsLaptopBattery() const { return &this->bIsLaptopBattery; } + [[nodiscard]] QBindable bindableNativePath() const { return &this->bNativePath; } + [[nodiscard]] QBindable bindableModel() const { return &this->bModel; } + [[nodiscard]] QBindable bindableReady() const { return &this->bReady; } signals: QSDOC_HIDE void readyChanged(); diff --git a/src/widgets/wrapper.hpp b/src/widgets/wrapper.hpp index f0a2a138..aca41727 100644 --- a/src/widgets/wrapper.hpp +++ b/src/widgets/wrapper.hpp @@ -139,8 +139,8 @@ protected: void printChildCountWarning() const; void updateGeometry(); - virtual void disconnectChild() {}; - virtual void connectChild() {}; + virtual void disconnectChild() {} + virtual void connectChild() {} QQuickItem* mWrapper = nullptr; QQuickItem* mAssignedWrapper = nullptr;