From 324fe9274d390337d541034408f5fbbbf04720c7 Mon Sep 17 00:00:00 2001 From: outfoxxed Date: Thu, 21 Nov 2024 19:45:21 -0800 Subject: [PATCH] all: remove unused dbus props and warnings for non-required ones --- src/dbus/dbusmenu/dbusmenu.hpp | 15 ++++++++------- src/services/mpris/player.hpp | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/dbus/dbusmenu/dbusmenu.hpp b/src/dbus/dbusmenu/dbusmenu.hpp index 1424c6d6..75d2c26a 100644 --- a/src/dbus/dbusmenu/dbusmenu.hpp +++ b/src/dbus/dbusmenu/dbusmenu.hpp @@ -122,9 +122,6 @@ signals: QSDOC_HIDE void iconThemePathChanged(); public: - Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, quint32, version); - Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QString, textDirection); - Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QString, status); Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QStringList, iconThemePath, &DBusMenu::iconThemePathChanged); void prepareToShow(qint32 item, qint32 depth); @@ -147,10 +144,14 @@ private slots: private: void updateLayoutRecursive(const DBusMenuLayout& layout, DBusMenuItem* parent, qint32 depth); - QS_DBUS_PROPERTY_BINDING(DBusMenu, pVersion, version, properties, "Version"); - QS_DBUS_PROPERTY_BINDING(DBusMenu, pTextDirection, textDirection, properties, "TextDirection"); - QS_DBUS_PROPERTY_BINDING(DBusMenu, pStatus, status, properties, "Status"); - QS_DBUS_PROPERTY_BINDING(DBusMenu, pIconThemePath, iconThemePath, properties, "IconThemePath"); + QS_DBUS_PROPERTY_BINDING( + DBusMenu, + pIconThemePath, + iconThemePath, + properties, + "IconThemePath", + false + ); DBusMenuInterface* interface = nullptr; }; diff --git a/src/services/mpris/player.hpp b/src/services/mpris/player.hpp index eb030dca..c618b7aa 100644 --- a/src/services/mpris/player.hpp +++ b/src/services/mpris/player.hpp @@ -408,8 +408,8 @@ private: QS_DBUS_PROPERTY_BINDING(MprisPlayer, pDesktopEntry, bDesktopEntry, appProperties, "DesktopEntry"); QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanQuit, bCanQuit, appProperties, "CanQuit"); QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanRaise, bCanRaise, appProperties, "CanRaise"); - QS_DBUS_PROPERTY_BINDING(MprisPlayer, pFullscreen, bFullscreen, appProperties, "Fullscreen"); - QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanSetFullscreen, bCanSetFullscreen, appProperties, "CanSetFullscreen"); + QS_DBUS_PROPERTY_BINDING(MprisPlayer, pFullscreen, bFullscreen, appProperties, "Fullscreen", false); + QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanSetFullscreen, bCanSetFullscreen, appProperties, "CanSetFullscreen", false); QS_DBUS_PROPERTY_BINDING(MprisPlayer, pSupportedUriSchemes, bSupportedUriSchemes, appProperties, "SupportedUriSchemes"); QS_DBUS_PROPERTY_BINDING(MprisPlayer, pSupportedMimeTypes, bSupportedMimeTypes, appProperties, "SupportedMimeTypes");