poz/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

io/fileview: use deleteLater() to delete file watchers

Browse source 
Fixes crashes when writing a file while watching it.
This commit is contained in:
outfoxxed 2025-06-09 21:44:34 -07:00
parent 91000a582b
commit 0224fa942b
Signed by untrusted user: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/io/fileview.cpp
View file

@ -490,7 +490,9 @@ void FileView::updatePath() {
} }
void FileView::updateWatchedFiles() { void FileView::updateWatchedFiles() {
delete this->watcher; // If inotify events are sent to the watcher after deletion and deleteLater
// isn't used, a use after free in the QML engine will occur.
if (this->watcher) this->watcher->deleteLater();
if (!this->targetPath.isEmpty() && this->bWatchChanges) { if (!this->targetPath.isEmpty() && this->bWatchChanges) {
qCDebug(logFileView) << "Creating watcher for" << this << "at" << this->targetPath; qCDebug(logFileView) << "Creating watcher for" << this << "at" << this->targetPath;