outfoxxed
680 contributions in the last 12 months
AprMayJunJulAugSepOctNovDecJanFebMarAprMonWedFri
Less
More
outfoxxed merged pull request quickshell/quickshell#1 2025-01-28 02:24:15 +00:00
feat: add color quantization ultility
outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

newlines on both sides

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

set null before emitting the event, as the emission triggers arbitrary user code which may be reentrant (e.g. changes source)

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

qCDebug

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

you can squish these lines together more, and should probably combine the ifs

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

unnecessary

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

use a normal char, qchar is utf16

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

== '' not "", "" causes an implicit string conversion

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

BINDABLE properties still need NOTIFY as a fallback (afaik, the qt documentation doesn't mention it either way so I keep NOTIFY)

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

newlines

outfoxxed suggested changes for quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility
outfoxxed pushed to master at quickshell/quickshell 2025-01-27 02:38:24 +00:00
9506c1bb62 docs: update CONTRIBUTING style guide
outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:14:09 +00:00
feat: add color quantization ultility

Also this is going to have issues due to qobject threading, as it will create a direct connection. Take a look at how FileViewOperation::finished works and is called.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Should trigger quantizeAsync(). You can use QQmlParserStatus::componentCompleted to delay the initial run until all properties are set as well.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Same as above

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

don't need the extra space when theres only 2 lines

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

This is a race condition, if another quantization task is started before this one finishes the new one won't run. Instead of canceling with isProcessing, keep a pointer to the old task to disconnect from before starting a new one.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Use either a char or an enum, not strings.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

< can be !=