outfoxxed
outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

BINDABLE properties still need NOTIFY as a fallback (afaik, the qt documentation doesn't mention it either way so I keep NOTIFY)

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility

newlines

outfoxxed suggested changes for quickshell/quickshell#1 2025-01-28 01:46:37 +00:00
feat: add color quantization ultility
outfoxxed pushed to master at quickshell/quickshell 2025-01-27 02:38:24 +00:00
9506c1bb62 docs: update CONTRIBUTING style guide
outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:14:09 +00:00
feat: add color quantization ultility

Also this is going to have issues due to qobject threading, as it will create a direct connection. Take a look at how FileViewOperation::finished works and is called.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Should trigger quantizeAsync(). You can use QQmlParserStatus::componentCompleted to delay the initial run until all properties are set as well.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Same as above

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

don't need the extra space when theres only 2 lines

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

This is a race condition, if another quantization task is started before this one finishes the new one won't run. Instead of canceling with isProcessing, keep a pointer to the old task to disconnect from before starting a new one.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Use either a char or an enum, not strings.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

< can be !=

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

single line if please

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Can be a bindable property, doesn't have to be but it can be.

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

Spaces between each get/set group

outfoxxed commented on pull request quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

functions above fields

outfoxxed suggested changes for quickshell/quickshell#1 2025-01-27 01:10:42 +00:00
feat: add color quantization ultility

In general also use auto x = y syntax over T x = y, and avoid T x(y).

outfoxxed pushed to master at outfoxxed/nixnew 2025-01-27 00:37:53 +00:00
88a355ebe4 qs: use SystemClock.date in clock
324d1aad9d qs: use Hyprland.visibleMask in notifs and tooltip
bfe0689d2e update lockfile
Compare 3 commits »
outfoxxed pushed to master at quickshell/quickshell 2025-01-26 11:57:30 +00:00
4f2610dece io/ipchandler: add prop get
outfoxxed pushed to master at quickshell/quickshell 2025-01-25 12:06:42 +00:00
9417d6fa57 core/command: deprecate qs msg
420529362f core/clock: expose date as a QDateTime
Compare 2 commits »
outfoxxed pushed to master at quickshell/quickshell 2025-01-25 09:01:12 +00:00
2df9839efd core/command: deprecate qs msg