diff --git a/CMakeLists.txt b/CMakeLists.txt index b5a6dff..8cb376d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -33,6 +33,7 @@ if (NOT DEFINED GIT_REVISION) COMMAND git rev-parse HEAD WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE GIT_REVISION + OUTPUT_STRIP_TRAILING_WHITESPACE ) endif() @@ -94,7 +95,7 @@ set(QT_QML_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/qml_modules) if (NOT NO_PCH) file(GENERATE OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/pchstub.cpp - CONTENT "" + CONTENT "// intentionally empty" ) add_library(qt-pch ${CMAKE_CURRENT_BINARY_DIR}/pchstub.cpp) diff --git a/src/core/main.cpp b/src/core/main.cpp index 78b7008..8dd7ec7 100644 --- a/src/core/main.cpp +++ b/src/core/main.cpp @@ -325,5 +325,7 @@ int qs_main(int argc, char** argv) { auto root = RootWrapper(configFilePath); QGuiApplication::setQuitOnLastWindowClosed(false); - return QCoreApplication::exec(); + auto code = QCoreApplication::exec(); + delete app; + return code; } diff --git a/src/core/plugin.hpp b/src/core/plugin.hpp index 8e16824..38c9ddc 100644 --- a/src/core/plugin.hpp +++ b/src/core/plugin.hpp @@ -17,7 +17,7 @@ public: virtual bool applies() { return true; } virtual void init() {} virtual void registerTypes() {} - virtual void constructGeneration(EngineGeneration& generation) {} // NOLINT + virtual void constructGeneration(EngineGeneration& /*unused*/) {} // NOLINT virtual void onReload() {} static void registerPlugin(QuickshellPlugin& plugin);