core: fix build warnings

CMakeLists.txt

@@ -33,6 +33,7 @@ if (NOT DEFINED GIT_REVISION)
 		COMMAND git rev-parse HEAD
 		WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
 		OUTPUT_VARIABLE GIT_REVISION
+		OUTPUT_STRIP_TRAILING_WHITESPACE
 	)
 endif()
 
@@ -94,7 +95,7 @@ set(QT_QML_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/qml_modules)
 if (NOT NO_PCH)
 	file(GENERATE
 		OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/pchstub.cpp
-		CONTENT ""
+		CONTENT "// intentionally empty"
 	)
 
 	add_library(qt-pch ${CMAKE_CURRENT_BINARY_DIR}/pchstub.cpp)

src/core/main.cpp

@@ -325,5 +325,7 @@ int qs_main(int argc, char** argv) {
 	auto root = RootWrapper(configFilePath);
 	QGuiApplication::setQuitOnLastWindowClosed(false);
 
-	return QCoreApplication::exec();
+	auto code = QCoreApplication::exec();
+	delete app;
+	return code;
 }

src/core/plugin.hpp

@@ -17,7 +17,7 @@ public:
 	virtual bool applies() { return true; }
 	virtual void init() {}
 	virtual void registerTypes() {}
-	virtual void constructGeneration(EngineGeneration& generation) {} // NOLINT
+	virtual void constructGeneration(EngineGeneration& /*unused*/) {} // NOLINT
 	virtual void onReload() {}
 
 	static void registerPlugin(QuickshellPlugin& plugin);