kosslan/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

service/tray: disconnect menu from handle on deletion

Browse source 
Fixes loaded being set to true after deleting the menu.
This commit is contained in:
outfoxxed 2024-09-15 15:32:01 -07:00
parent bdc9fe958b
commit 84e3f04f3c
Signed by: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/dbus/dbusmenu/dbusmenu.cpp
View file

@ -545,6 +545,9 @@ void DBusMenuHandle::onMenuPathChanged() {
qCDebug(logDbusMenu) << "Updating" << this << "with refcount" << this->refcount; qCDebug(logDbusMenu) << "Updating" << this << "with refcount" << this->refcount;
if (this->mMenu) { if (this->mMenu) {
// Without this, layout updated can be sent after mMenu is set to null,
// leaving loaded = true while mMenu = nullptr.
QObject::disconnect(&this->mMenu->rootItem, nullptr, this, nullptr);
this->mMenu->deleteLater(); this->mMenu->deleteLater();
this->mMenu = nullptr; this->mMenu = nullptr;
this->loaded = false; this->loaded = false;