kosslan/quickshell
1
0
Fork 0
forked from quickshell/quickshell
Code Pull requests Activity

crash: fix off-end read when copying environ array

Browse source
This commit is contained in:
outfoxxed 2024-09-02 22:19:36 -07:00
parent 397476244c
commit 465d5402f2
Signed by: outfoxxed
GPG key ID: 4C88A185FB89301E
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/crash/handler.cpp
View file

@ -126,8 +126,10 @@ bool CrashHandlerPrivate::minidumpCallback(
auto populateEnv = [&]() { auto populateEnv = [&]() {
auto senvi = 0; auto senvi = 0;
while (envi < 4095) { while (envi != 4095) {
env[envi++] = environ[senvi++]; // NOLINT auto var = environ[senvi++]; // NOLINT
if (var == nullptr) break;
env[envi++] = var;
} }
env[envi] = nullptr; env[envi] = nullptr;