all: fix clang 18 lints

src/services/greetd/connection.hpp

@@ -6,6 +6,7 @@
 #include <qobject.h>
 #include <qqmlintegration.h>
 #include <qtmetamacros.h>
+#include <qtypes.h>
 
 ///! State of the Greetd connection.
 /// See @@Greetd.state.
@@ -15,7 +16,7 @@ class GreetdState: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		Inactive = 0,
 		Authenticating = 1,
 		ReadyToLaunch = 2,

src/services/mpris/player.hpp

@@ -23,7 +23,7 @@ class MprisPlaybackState: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		Stopped = 0,
 		Playing = 1,
 		Paused = 2,
@@ -41,7 +41,7 @@ class MprisLoopState: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		None = 0,
 		Track = 1,
 		Playlist = 2,

src/services/notifications/notification.hpp

@@ -8,6 +8,7 @@
 #include <qobject.h>
 #include <qqmlintegration.h>
 #include <qtmetamacros.h>
+#include <qtypes.h>
 
 #include "../../core/retainable.hpp"
 #include "../../core/util.hpp"
@@ -24,7 +25,7 @@ class NotificationUrgency: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		Low = 0,
 		Normal = 1,
 		Critical = 2,
@@ -42,7 +43,7 @@ class NotificationCloseReason: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		/// The notification expired due to a timeout.
 		Expired = 1,
 		/// The notification was explicitly dismissed by the user.

src/services/notifications/server.cpp

@@ -124,7 +124,7 @@ void NotificationServer::tryRegister() {
 }
 void NotificationServer::onServiceUnregistered(const QString& /*unused*/) {
 	qCDebug(logNotifications) << "Active notification server unregistered, attempting registration";
-	this->tryRegister();
+	NotificationServer::tryRegister();
 }
 
 void NotificationServer::CloseNotification(uint id) {

src/services/notifications/server.hpp

@@ -63,7 +63,7 @@ signals:
 	// NOLINTEND
 
 private slots:
-	void onServiceUnregistered(const QString& service);
+	static void onServiceUnregistered(const QString& service);
 
 private:
 	explicit NotificationServer();

src/services/pam/conversation.hpp

@@ -1,13 +1,12 @@
 #pragma once
 
-#include <utility>
-
 #include <qloggingcategory.h>
 #include <qobject.h>
 #include <qqmlintegration.h>
 #include <qsocketnotifier.h>
 #include <qtclasshelpermacros.h>
 #include <qtmetamacros.h>
+#include <qtypes.h>
 
 #include "ipc.hpp"
 
@@ -21,7 +20,7 @@ class PamResult: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		/// Authentication was successful.
 		Success = 0,
 		/// Authentication failed.
@@ -44,7 +43,7 @@ class PamError: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		/// Failed to start the pam session.
 		StartFailed = 1,
 		/// Failed to try to authenticate the user.

src/services/pam/subprocess.hpp

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <iostream>
+#include <iostream> // NOLINT std::cout
 
 #include <security/pam_appl.h>
 

src/services/pipewire/link.hpp

@@ -21,7 +21,7 @@ class PwLinkState: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : qint8 {
 		Error = PW_LINK_STATE_ERROR,
 		Unlinked = PW_LINK_STATE_UNLINKED,
 		Init = PW_LINK_STATE_INIT,

src/services/pipewire/node.hpp

@@ -87,7 +87,7 @@ public:
 	Q_INVOKABLE static QString toString(qs::service::pipewire::PwAudioChannel::Enum value);
 };
 
-enum class PwNodeType {
+enum class PwNodeType : quint8 {
 	Untracked,
 	Audio,
 };

src/services/status_notifier/dbus_item_types.cpp

@@ -7,6 +7,7 @@
 #include <qlogging.h>
 #include <qmetatype.h>
 #include <qsysinfo.h>
+#include <qtversionchecks.h>
 #include <qtypes.h>
 
 bool DBusSniIconPixmap::operator==(const DBusSniIconPixmap& other) const {

src/services/status_notifier/item.hpp

@@ -26,7 +26,7 @@ namespace Status { // NOLINT
 Q_NAMESPACE;
 QML_ELEMENT;
 
-enum Enum {
+enum Enum : quint8 {
 	/// A passive item does not convey important information and can be considered idle. You may want to hide these.
 	Passive = 0,
 	/// An active item may have information more important than a passive one and you probably do not want to hide it.
@@ -43,7 +43,7 @@ namespace Category { // NOLINT
 Q_NAMESPACE;
 QML_ELEMENT;
 
-enum Enum {
+enum Enum : quint8 {
 	/// The fallback category for general applications or anything that does
 	/// not fit into a different category.
 	ApplicationStatus = 0,

src/services/upower/device.hpp

@@ -20,7 +20,7 @@ class UPowerDeviceState: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		Unknown = 0,
 		Charging = 1,
 		Discharging = 2,
@@ -44,7 +44,7 @@ class UPowerDeviceType: public QObject {
 	QML_SINGLETON;
 
 public:
-	enum Enum {
+	enum Enum : quint8 {
 		Unknown = 0,
 		LinePower = 1,
 		Battery = 2,